added support for apostrophe emojis#4523
Merged
engelgabriel merged 2 commits intoRocketChat:developfrom Oct 4, 2016
MaciejKus:develop
Merged
added support for apostrophe emojis#4523engelgabriel merged 2 commits intoRocketChat:developfrom MaciejKus:develop
engelgabriel merged 2 commits intoRocketChat:developfrom
MaciejKus:develop
Conversation
changes to single quotes
rodrigok
approved these changes
Oct 4, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #2013
A simple line of regex in emojiParser.js to change
'to ' and then a second line after to change ' back to'The second line might not be needed, as everything seemed to work fine in my demo, but just in case the apostrophe needs to be put back to
'it is there.Emjois which use the apostrophe such as :') now work as expected.