Skip to content

Fix search not coming up#545

Merged
rodrigok merged 2 commits intoRocketChat:masterfrom
geekgonecrazy:patch-2
Aug 22, 2015
Merged

Fix search not coming up#545
rodrigok merged 2 commits intoRocketChat:masterfrom
geekgonecrazy:patch-2

Conversation

@geekgonecrazy
Copy link
Contributor

This fixes #531

Tested this on mac / windows / linux. Super + p on windows and linux is a no go.

On the gnome display environment in linux it actually is bound to changing between mirrored and extended for your monitors.

@rodrigok
Copy link
Member

Maybe you can accept ctrlKey and metaKey?

@rodrigok
Copy link
Member

I prefer Meta + P (Command + P) because this is the shortcut of sublime and chorme dev tools to navigate in files in Mac.

@rodrigok rodrigok added this to the v1.0 milestone Aug 21, 2015
@geekgonecrazy
Copy link
Contributor Author

Switched from just ctrl to ctrl or meta.

rodrigok added a commit that referenced this pull request Aug 22, 2015
@rodrigok rodrigok merged commit c0fce84 into RocketChat:master Aug 22, 2015
@rodrigok
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments