Add REST API method to list online users in a room#5502
Add REST API method to list online users in a room#5502engelgabriel merged 6 commits intoRocketChat:developfrom
Conversation
|
|
graywolf336
left a comment
graywolf336
left a comment
There was a problem hiding this comment.
Thanks for this pull request, I apologize for missing this route when I moved what I thought was everything over.
| get: function() { | ||
| const room = findChannelById(this.queryParams.roomId); | ||
|
|
||
| if (room.statusCode) { |
There was a problem hiding this comment.
Can you merge the latest code? As this line of code isn't needed any more.
| } | ||
| }); | ||
|
|
||
| RocketChat.API.v1.addRoute('channels.online', { authRequired: true }, { |
There was a problem hiding this comment.
Can you add this to the groups as well? And if you're up for it, create the documentation on this over on our docs? https://github.com/RocketChat/Rocket.Chat.Docs/tree/master/6.%20Developer%20Guides/REST%20API
|
@graywolf336 can you do the sync so we can merge this? |
|
@graywolf336 Can you review this again? |
|
@rodrigok What would you think about changing it from just |
|
@graywolf336 Done :) |
5 participants
@RocketChat/core
This pull request re-implements the API method to get online users in a room. It was already implemented by #2918 but it got lost when moving the api to /v1 namespace.