Add relation between client cache and user’s token#5603
Merged
engelgabriel merged 1 commit intodevelopfrom Jan 16, 2017
Merged
Conversation
Contributor
|
@rodrigok this looks good. What does doing this accomplish? Clears it out if the user logs out? Just making sure 😄 |
Member
Author
|
@geekgonecrazy Yes, it is relating the cache data with the user's token. When cache is loading we compare the saved token with the current token, if the token is different we clear the cache and load all from database. We are clearing the cache when users logout, but there is an edge case where the token expires and meteor does not remove the token (logout) and shows the login screen, with this change the cache will be cleared even if the logout does not do the work. We are not enabling this relation for |
engelgabriel
approved these changes
Jan 16, 2017
This was referenced Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5537
@RocketChat/core