Added checks to updateMessage and deleteMessage#621
Merged
engelgabriel merged 3 commits intoRocketChat:masterfrom Aug 29, 2015
geekgonecrazy:permission-checks
Merged
Added checks to updateMessage and deleteMessage#621engelgabriel merged 3 commits intoRocketChat:masterfrom geekgonecrazy:permission-checks
engelgabriel merged 3 commits intoRocketChat:masterfrom
geekgonecrazy:permission-checks
Conversation
Contributor
Author
|
Oops.. deleted my remote before merge. |
server/methods/deleteUser.coffee
Outdated
Member
There was a problem hiding this comment.
I only can delete admin users?
Contributor
Author
There was a problem hiding this comment.
yeah my bad. Forgot this is an action being done only by the admin. Reverted
engelgabriel
added a commit
that referenced
this pull request
Aug 29, 2015
Added checks to updateMessage and deleteMessage
18 tasks
This was referenced Mar 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only two I could find that still needed it.