File Attachments - for now at least post a message that a file was uploaded#6309
Closed
kable-wilmoth wants to merge 4 commits intoRocketChat:developfrom
Closed
File Attachments - for now at least post a message that a file was uploaded#6309kable-wilmoth wants to merge 4 commits intoRocketChat:developfrom
kable-wilmoth wants to merge 4 commits intoRocketChat:developfrom
Conversation
added 4 commits
March 7, 2017 16:36
Introduced ES2015 Import/Export to resolve dependencies
4 tasks
lindoelio
reviewed
Sep 6, 2017
|
|
||
| api.addFiles('logger.js', 'server'); | ||
| api.addFiles('settings.js', 'server'); | ||
| api.addFiles('RocketAdapter.js', 'server'); |
Contributor
There was a problem hiding this comment.
Avoid using UpperCamelCase for file names. Prefer lowerCamelCase instead.
| api.addFiles('logger.js', 'server'); | ||
| api.addFiles('settings.js', 'server'); | ||
| api.addFiles('RocketAdapter.js', 'server'); | ||
| api.addFiles('SlackAdapter.js', 'server'); |
Contributor
There was a problem hiding this comment.
Avoid using UpperCamelCase for file names. Prefer lowerCamelCase instead.
| @@ -0,0 +1,58 @@ | |||
| Config: | |||
| _id: 'SlackBridge_Enabled', | ||
| value: true | ||
| }, | ||
| i18nLabel: 'FileUpload' |
Contributor
There was a problem hiding this comment.
The term 'FileUpload' may be dubious. I suggest using a specific entry to mention uploading activated Slack Bridge files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Until we have full bi-directional file uploading supported via the SlackBridge, lets at least post a message so that one knows it occurred.
There have been many conversations (rocket <--> slack) where the other party didn't realize a screen shot/txt file had been uploaded and then the follow up messages had no context. At lest now they will see a message that a file was uploaded and then can take action (switch group chat tools) to view it.
Sorry, this again, was based on a previous merge request #6282 . So you can focus on the last commit.