[NEW] Delete all Attachments / Files from a Channel /Chat #7383
[NEW] Delete all Attachments / Files from a Channel /Chat #7383danilomiranda wants to merge 4 commits intoRocketChat:developfrom
Conversation
Plus an indicator of hoy much files are displayed
geekgonecrazy
left a comment
geekgonecrazy
left a comment
There was a problem hiding this comment.
Thanks for opening this!
I know English is not likely your native language. But just a few changes to wording.
| "Your_email_has_been_queued_for_sending": "Your email has been queued for sending", | ||
| "Your_entry_has_been_deleted": "Your entry has been deleted.", | ||
| "Your_file_has_been_deleted": "Your file has been deleted.", | ||
| "Your_files_are_been_deleted": "Your files are been deleted.", |
There was a problem hiding this comment.
If this is for when its still deleting. You might want to change the wording here to:
Your files are being deleted.
There was a problem hiding this comment.
I think this string is used after deletion is successful, so I think it should be
Your files have been deleted.
There was a problem hiding this comment.
No @gdelavald, we display the string during the delete process. I delete more than 800 files and the modal only close when all files are erased.
| "Yes_unarchive_it": "Yes, unarchive it!", | ||
| "Yes_clear_all": "Yes, clear all!", | ||
| "Yes_delete_it": "Yes, delete it!", | ||
| "Yes_delete_all_it": "Yes, delete all it!", |
There was a problem hiding this comment.
I'd change the wording here to:
Yes, delete them all!
| "You_should_name_it_to_easily_manage_your_integrations": "You should name it to easily manage your integrations.", | ||
| "You_will_not_be_able_to_recover": "You will not be able to recover this message!", | ||
| "You_will_not_be_able_to_recover_file": "You will not be able to recover this file!", | ||
| "You_will_not_be_able_to_recover_all_files": "You will not be able to recover all files!", |
There was a problem hiding this comment.
To fit with the message above (recover this file), I would suggest doing:
You will not be able to recover these files.
danilomiranda
force-pushed
the
delAllAttach
branch
from
d61191c to
9754e8c
Compare
| "Your_email_has_been_queued_for_sending": "Your email has been queued for sending", | ||
| "Your_entry_has_been_deleted": "Your entry has been deleted.", | ||
| "Your_file_has_been_deleted": "Your file has been deleted.", | ||
| "Your_files_are_been_deleted": "Your files are being deleted.", |
There was a problem hiding this comment.
Can you update the variable name too? A little thing :)
There was a problem hiding this comment.
Hey, sorry to petpeeve on this, but since it's the success message after deleting multiple files, it should read
Your files have been deleted.
There was a problem hiding this comment.
Yeah @geekgonecrazy , totally. I’ll do that asap :) thanks
There was a problem hiding this comment.
@gdelavald I see your point, but the message appears during the deletion. We can see that with a lot of files
There was a problem hiding this comment.
@danilomiranda / @gdelavald I think the issue is that on large channels with lots of files the box will show while it's still deleting and won't go away until finished
There was a problem hiding this comment.
Yeah it makes sense, but I would rather show a loading indicator while it's deleting and a successful message when it's done, I'm not sure what kind of logic that would need though.
|
|
||
| self.files.map((file) => { | ||
| return removeFiles(file, msg); | ||
| }); |
There was a problem hiding this comment.
.map is synchronous. So you could actually put that swal for success on multiple here.
As far as that goes... the swal for success really shouldn't be being shown until its actually finished. So might just move the swal below this whole block. And remove the text for TAPi18n.__('Your_files_are_being_deleted');
There was a problem hiding this comment.
The map function run very fast b/c the RocketChat.models.Uploads.remove is asynchronous. I tried to use the Meteor.wrapAsync without succes. move the swal to de end of the block doesn't delay the success message
|
@danilomiranda Can you fix the conflict? |
|
@rodrigok The @marceloschmidt is helping me with that. |
|
@danilomiranda May I help fixing the conflicts to get this one in? |
|
@danilomiranda Will be any further progress on the failing checks? |
|
@danilomiranda this issue was closed here #11236 sorry about that =/ |
7 participants
@RocketChat/core
Closes #6193
A new feature to remove all files from room with one click.
Plus an indicator of how much files are displayed