[NEW] Send too long messages as attachment#7676
[NEW] Send too long messages as attachment#7676lindoelio wants to merge 10 commits intoRocketChat:developfrom lindoelio:attach-message-too-long
Conversation
| "Mentions": "Mentions", | ||
| "Mentions_default": "Mentions (default)", | ||
| "Message": "Message", | ||
| "Message_AllowAttachTooLongMessages": "Allow attach too long messages", |
There was a problem hiding this comment.
Convert long messages to attachment would be a bit better. Would also change the i18n name.
There was a problem hiding this comment.
Yep... This message appear for admins so that they allow/deny the converting of long messages to attachment. It sounds good: "Message_AllowConvertLongMessagesToAttachment"?
| closeOnConfirm: true | ||
| }, () => { | ||
| // Transform message to attachment... | ||
| const contentType = 'application/vnd.openxmlformats-officedocument.wordprocessingml.document'; |
There was a problem hiding this comment.
Can we have a simpler format here? Having it as plain/text would be way better for compatibility.
There was a problem hiding this comment.
Agreed... We need a more compatible format
There was a problem hiding this comment.
Agreed. I'll to perform it.
| } | ||
|
|
||
| fileUpload = function(filesToUpload) { | ||
| performFileUpload = function(file, fileName, fileDescription) { |
There was a problem hiding this comment.
Why the modifications here? Couldn't we use the default file upload?
There was a problem hiding this comment.
@gdelavald, We are using the default file upload here still. What I did was generalize part of original fileUpload function so that it could be more reusable. You can see that the fileUpload function have calling "performFileUpload" function too so perform the file upload core activity. :-)
|
@lindoelio can you check the comments and make some changes? I really like this feature. 👍 for doing this. |
|
Message box doesn't send message on |
|
@gdelavald did this last commit fix it for you? |
|
Due to conflicts and non-existing fork anymore, I made a new PR: #13819 |
7 participants
@RocketChat/core
Closes #7267
This PR include:
Settings for that RocketChat admins can to allow/deny the sending of too long messages as attachment. URL target: ../admin/Message.
Offer for user to send too long messages as attachment.
