Fix issue where the first inserted user is not assigned the 'admin' role#836
Merged
Fix issue where the first inserted user is not assigned the 'admin' role#836
Conversation
role. Modifies admin role assignment to check if the inserted user is the first user based on sorted query using "createdAt". Originally, the admin role assignment was done onCreateUser before the user record was inserted into the db. It assigned the 'admin' role to a user if no other user existed in the db. However, with the change to insertUserDoc, the 'admin' assignment is done AFTER the first user is inserted and the original query logic (check if any user exists) no longer applies
rodrigok
added a commit
that referenced
this pull request
Sep 19, 2015
Fix issue where the first inserted user is not assigned the 'admin' role
This was referenced Mar 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies admin role assignment to check if the inserted user is the
first user based on sorted query using "createdAt".
Originally, the admin role assignment was done onCreateUser before
the user record was inserted into the db. It assigned the 'admin' role
to a user if no other user existed in the db. However, with the change
to insertUserDoc, the 'admin' assignment is done AFTER the first user
is inserted and the original query logic (check if any user exists) no
longer applies