[FIX] Change wording to start DM from info panel#8799
Merged
ggazzo merged 1 commit intoRocketChat:developfrom Apr 15, 2020
Merged
[FIX] Change wording to start DM from info panel#8799ggazzo merged 1 commit intoRocketChat:developfrom
ggazzo merged 1 commit intoRocketChat:developfrom
Conversation
Contributor
|
Nice catch! This was a little difficult figuring out initially; ended up using group channels to begin with until I discovered this. |
Contributor
|
I would tend to agree. @RocketChat/core I know this is part of our new redesign also. Opening a Should we change it to |
HammyHavoc
previously approved these changes
Nov 7, 2017
Member
|
I agree. But the new UI is already touching this area, so I would say to opening a PR against the new branch.. Also, there is no translation for |
sampaiodiego
requested changes
Nov 7, 2017
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
There is no translation for "Direct Message", can you please add it as well?
also, can you please target your changes to contextual-bar-redesign branch?
Contributor
|
@bryandesrosiers @HammyHavoc what do you guys think in context of new UI?
|
geekgonecrazy
changed the title
Contributor
|
"Conversation" isn't a verb, "Video Call" is; with that in mind, "Direct Message" makes far more sense. :- ) Looking good though lads, really pretty UX! 👍 |
Contributor
|
Hm.. maybe "Start Conversation" ? @karlprieb @arthurgiustina This is a design thing. Thoughts? :) |
Contributor
|
I could get behind that idea if we're also going to change 'Direct Messages' elsewhere to 'Conversations'. :- ) Loving the direction things are going; consistency! |
|
|
ggazzo
approved these changes
Apr 15, 2020
ggazzo
changed the title
gabriellsh
added a commit
that referenced
this pull request
Apr 15, 2020
…mailer * 'develop' of github.com:RocketChat/Rocket.Chat: (93 commits) [FIX] Red color error outline is not removed after password update (#16536) [FIX] Change wording to start DM from info panel (#8799) New hooks for RouterContext (#17305) [FIX] SAML assertion signature enforcement (#17278) [FIX] LDAP users lose session on refresh (#17302) [NEW] Add MMS support to Voxtelesys (#17217) [FIX] Popover component doesn't have scroll (#17198) [FIX] Omnichannel SMS / WhatsApp integration errors due to missing location data (#17288) [FIX] User search on directory not working correctly (#17299) [FIX] Can not save Unread Tray Icon Alert user preference (#16288) (#16313) [FIX] Variable rendering problem on Import recent history page (#15997) [FIX] Admin panel custom sounds, multiple sound playback fix and added single play/pause button (#16215) [FIX] Discussions created from inside DMs were not working (#17282) [FIX] translation for nl (#16742) [FIX] No maxlength defined for custom user status (#16534) [FIX] Directory users email sort button (#16606) [FIX] In Create a New Channel, input should be focused on channel name instead of invite users (#16405) [FIX] Email not verified message (#16236) [FIX] Directory default tab (#17283) Update ru.i18n.json (#16869) ...
gabriellsh
added a commit
that referenced
this pull request
Apr 15, 2020
…users_and_rooms * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] "Invalid Invite" message when registration is disabled (#17226) [FIX] Red color error outline is not removed after password update (#16536) [FIX] Change wording to start DM from info panel (#8799) New hooks for RouterContext (#17305) [FIX] SAML assertion signature enforcement (#17278) [FIX] LDAP users lose session on refresh (#17302) [NEW] Add MMS support to Voxtelesys (#17217) [FIX] Popover component doesn't have scroll (#17198)
ggazzo
added a commit
that referenced
this pull request
Apr 15, 2020
…dm/mailer * 'adm/mailer' of github.com:RocketChat/Rocket.Chat: (79 commits) removed unecessary prop Fixed sendMail function Removed Log, Success message Permissions added route component [FIX] "Invalid Invite" message when registration is disabled (#17226) Added route, error handling. [FIX] Red color error outline is not removed after password update (#16536) [FIX] Change wording to start DM from info panel (#8799) New hooks for RouterContext (#17305) [FIX] SAML assertion signature enforcement (#17278) [FIX] LDAP users lose session on refresh (#17302) [NEW] Add MMS support to Voxtelesys (#17217) [FIX] Popover component doesn't have scroll (#17198) [FIX] Omnichannel SMS / WhatsApp integration errors due to missing location data (#17288) [FIX] User search on directory not working correctly (#17299) [FIX] Can not save Unread Tray Icon Alert user preference (#16288) (#16313) [FIX] Variable rendering problem on Import recent history page (#15997) [FIX] Admin panel custom sounds, multiple sound playback fix and added single play/pause button (#16215) [FIX] Discussions created from inside DMs were not working (#17282) ...
dudizilla
added a commit
that referenced
this pull request
Apr 21, 2020
…nto view-logs * 'develop' of https://github.com/RocketChat/Rocket.Chat: (31 commits) Fixed componentes width (#17322) [IMPROVE] Administration -> Mailer Rewrite to React. (#17191) Regression: Storybook added flowrouter group mock (#17321) [NEW] Feature/custom oauth mail field and interpolation for mapped fields (#15690) [FIX] "Invalid Invite" message when registration is disabled (#17226) [FIX] Red color error outline is not removed after password update (#16536) [FIX] Change wording to start DM from info panel (#8799) New hooks for RouterContext (#17305) [FIX] SAML assertion signature enforcement (#17278) [FIX] LDAP users lose session on refresh (#17302) [NEW] Add MMS support to Voxtelesys (#17217) [FIX] Popover component doesn't have scroll (#17198) [FIX] Omnichannel SMS / WhatsApp integration errors due to missing location data (#17288) [FIX] User search on directory not working correctly (#17299) [FIX] Can not save Unread Tray Icon Alert user preference (#16288) (#16313) [FIX] Variable rendering problem on Import recent history page (#15997) [FIX] Admin panel custom sounds, multiple sound playback fix and added single play/pause button (#16215) [FIX] Discussions created from inside DMs were not working (#17282) [FIX] translation for nl (#16742) [FIX] No maxlength defined for custom user status (#16534) ...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor word change from "Conversation" to "Direct Message". To keep UI consistency with the left side bar.
@RocketChat/core
Closes #ISSUE_NUMBER