[NEW] Add avatar support to custom oauth client and server#9045
[NEW] Add avatar support to custom oauth client and server#9045geekgonecrazy wants to merge 15 commits intodevelopfrom
Conversation
|
So I wanted to make logging in with oauth set avatar... but apparently logging in via a service and logging in via oauth travel down two separate paths... Which means a lot of the logic we are applying is actually getting skipped when logging in with oauth. |
|
I'll save resolving oauth skipping normal user checks for another PR. This at least adds it as an option in avatar suggestion. |
geekgonecrazy
changed the title
|
@geekgonecrazy can you fix the conflicts? |
| return ['gravatar', 'facebook', 'google', 'github', 'gitlab', 'linkedIn', 'twitter'] | ||
| .map((service) => { | ||
|
|
||
| if (suggestions.avatars) { |
There was a problem hiding this comment.
Why remove the list of services? That will remove the suggestions for login to get the avatar
There was a problem hiding this comment.
This makes it use any provider instead of limiting to just these
There was a problem hiding this comment.
But them you remove the suggestions for login, is that expected?
There was a problem hiding this comment.
Ah... I see what you mean. So this will get list of suggestions as well as show for them to link their account.
So best way to handle is probably to add in the suggestions list to return even those that aren't already linked.
I'll take another look to see if can make that happen.
There was a problem hiding this comment.
@geekgonecrazy can you take another look at fixing this?
| return ['gravatar', 'facebook', 'google', 'github', 'gitlab', 'linkedIn', 'twitter'] | ||
| .map((service) => { | ||
|
|
||
| if (suggestions.avatars) { |
There was a problem hiding this comment.
@geekgonecrazy can you take another look at fixing this?
|
Not related to this issue but similar. Maybe support PR that I create long ago for custom avatar sources? #7929 |
|
Not sure how to handle this or I'd finish. |
7 participants
Brings in avatar from oauth as an option in profile.
Ideally... it would actually try to set it. But oauth skips the avatar set step. Once that is fixed the custom oauth will be presented as an avatar option and will auto set.