Conversation
gdelavald
force-pushed
the
livestream-tab
branch
from
285690a to
9861349
Compare
ggazzo
requested changes
Dec 29, 2017
karlprieb
previously requested changes
Dec 29, 2017
acinader
reviewed
Jan 27, 2018
14 tasks
….Chat into livestream-tab
ggazzo
approved these changes
Jan 30, 2018
rodrigok
approved these changes
Jan 31, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
This PR adds a new feature which allows admins to enable a livestream tab on channels (public and private), the tab's livestream source can be edited by users who have the
edit-roompermission. Every user on the channel can see the tab and watch the livestream once it is set.Currently we are using youtube video player, so this is a limiting factor for other APIs at the moment.
Livestream Tab for users:
Livestream Tab for users with
edit-roompermission:Livestream Tab input for video source:
Livestream Tab without a video source:
Livestream Tab without a video source for users with
edit-roompermission:Admin panel settings for Livestream:
Livestream Popout component:
Livestream Popout component minimized:
