[NEW] Announcement bar color wasn't using color from theming variables#9367
Merged
rodrigok merged 2 commits intoRocketChat:developfrom Mar 7, 2018
intwarehq:fix-announcement-bar-color
Merged
[NEW] Announcement bar color wasn't using color from theming variables#9367rodrigok merged 2 commits intoRocketChat:developfrom intwarehq:fix-announcement-bar-color
rodrigok merged 2 commits intoRocketChat:developfrom
intwarehq:fix-announcement-bar-color
Conversation
Member
|
@cyclops24 could you post screen shots of what it looks before and now? Thanks |
Contributor
Author
|
@rodrigok Before we can't change |
Member
|
So, the idea is to keep the primary base color to the announcement bar? @karlprieb @ggazzo what do you think? |
Contributor
Author
|
Yes @rodrigok I think it's better. What do you think guys? /CC: @rodrigok , @karlprieb , @ggazzo |
karlprieb
approved these changes
Mar 6, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR read
colorandbackground-colorforannouncement-barfrom color setting.