[FIX] Subscriptions not removed when removing user

[rodrigok]

Bypass the cache and find the subscriptions directly from database to prevent the in memory changes while deleting.

The for each of the array in memory does not works cuz the array is changing the size.

@RocketChat/core

Closes #6535

[mrsimpson]

@rodrigok what do you think about a migration which removes inconsistent subscriptions? While the fix prevents new issues, the obsolete subscriptions are aasige problem in existing installations.

[rodrigok]

@mrsimpson Sure, but I don't think it should be a migration, I'll see how we could create and admin option to run the consistency fix, so I'll merge this now.

Thanks

[metalcated]

Once this is pushed into stable builds will this fix the existing problems for people affected by this bug?

[geekgonecrazy]

This will only keep the problem from effecting new cases, does not fix the ones that have already had this happen

[Dirk23]

@geekgonecrazy Hi. It seems I have that problem with some users. Is there a fix for existing cases?

[geekgonecrazy]

you could likely write a mongo query to do something like:

nouser = []
db.rocketchat_subscription.find({t:'d'}).forEach(function(subscription) {
  if (!db.users.findOne({_id: subscription.u._id})) {
    nouser.push(subscription);
  }
})

Then from there you could loop over nouser and delete the subscriptions that don't have a user

if your problem is instead that you have subscriptions hanging around in your channel list for users that are no more... you could use same loop. Instead take subscription.rid and look for rooms that exist for it. If no room exists for that subscription you could delete.

[Dirk23]

@geekgonecrazy thank you for your reply, but this query finds 0 entrys. Maybe my problem is different to the one in this thread?
I have users wich cant Direct Message each other. User2 tries to DM User1 but RocketChat Displays: No User with the name "User1" found. User3 can DM User1 without any Problem. User1 can DM to User2 and User2 gets a PushMessage, but cant display that message in RocketChat, because User2 sees the Errormessage

[geekgonecrazy]

Did user1 at any point delete their user and then create an account with the exact same username?

[Dirk23]

Yes. the User was deleted and recreated once iirc.