[FIX] Fixes bug in latex-parsing#9715
Closed
c0dzilla wants to merge 2 commits intoRocketChat:developfrom
Closed
Conversation
nusje2000
approved these changes
Feb 15, 2018
Member
Contributor
Author
|
@engelgabriel presently latex parsing and markdown parsing callbacks on a message occur independently with latex parsing at higher priority. Latex parsing can be disabled in case inline/block code match occurs. Thoughts? |
|
@c0dzilla I think the question should be, what would a user use more often. I think, based on my use case, people use codeblocks more often than latex parsing. Altho latex parsing could be usefull in some cases, I dont think it should be at a higher priority than inline/block code. But that is my opinion |
Contributor
Author
|
@engelgabriel what is the status on this? Is there anything needed to be done? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

@RocketChat/core
Closes #9683
Latex rendering function was returning incorrect value leading to resulting message being of the form '=!=<Random.id()>=!='. This pr fixes this.