[FIX] Apostrophe-containing URL misparsed#9739
Merged
rodrigok merged 1 commit intoRocketChat:developfrom Mar 26, 2018
Merged
Conversation
lunaticmonk
force-pushed
the
url-detection
branch
from
6e3f529 to
b18b179
Compare
geekgonecrazy
changed the title
geekgonecrazy
changed the title
lunaticmonk
force-pushed
the
url-detection
branch
from
64950cf to
71631bd
Compare
Contributor
Author
|
@sampaiodiego @rafaelks Please review. |
lunaticmonk
force-pushed
the
url-detection
branch
3 times, most recently
from
226ee2a to
6923a6d
Compare
Contributor
Author
|
@geekgonecrazy @karlprieb please review. |
lunaticmonk
force-pushed
the
url-detection
branch
from
6923a6d to
970362e
Compare
karlprieb
approved these changes
Feb 26, 2018
|
Bump on getting this reviewed? Anything I can do to help? |
rodrigok
changed the title
Member
|
this is breaking messages inside an element, for example: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #9485
Closes #9976
Earlier when we tried to send the url like
https://foo.com/t='a'&s=1, it wasnt getting detected properly.Now it gets detected correctly: