[NEW] Set Document Domain property in IFrame#9751
Merged
rodrigok merged 8 commits intoRocketChat:developfrom Jun 20, 2018
Merged
[NEW] Set Document Domain property in IFrame#9751rodrigok merged 8 commits intoRocketChat:developfrom
rodrigok merged 8 commits intoRocketChat:developfrom
Conversation
sampaiodiego
requested changes
Apr 10, 2018
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
@kb0304 thank you for you contribution.
I'm not sure about the setting location, since it is not related to Accounts, also it needs to have the iframe auth enabled to work which does not seem right as well.
do you mind changing the setting to General section and removing its dependency with Accounts_iframe_enabled ? thank you again
kb0304
force-pushed
the
bugfix-7474
branch
2 times, most recently
from
0fd791a to
ddef7e0
Compare
Contributor
Author
|
@sampaiodiego Thank you for the review. |
rodrigok
approved these changes
Jun 20, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #7474
Added a new setting to General section that lets you set custom document.domain property.
Also, since the setting is set before calling the custom scripts, the existing users wouldn't face issues due to the added setting option.