[FIX] No pattern for user's status text capitalization#9783
[FIX] No pattern for user's status text capitalization#9783rodrigok merged 1 commit intoRocketChat:developfrom
Conversation
|
@rafaelks @JSzaszvari Please review. |
|
@sumedh123 can't we do that using only CSS? @engelgabriel do we want that? I really don't see the problem with lowercase on that case. |
|
@karlprieb yes, IF we do it, should be ONLY css, but I don't think we should force this here, we should just fix the translation files and make sure we are using the same string in all places. |
|
@karlprieb @engelgabriel Should I try this with CSS only or do we follow any other approach? |
|
@sumedh123 As Gabriel said, change the i18n setup so that it's all the same and using the same string in every place. |
|
But we really want that? I think it's better to be lowercase. What you guys think? @RocketChat/core |
|
@karlprieb I prefer all status in lowercase (in all places). |
|
Yeah I think visually it looks good lowercase |
7ab51e6 to
737f7d7
Compare
|
@karlprieb @geekgonecrazy Please review. |
737f7d7 to
e311c5b
Compare
karlprieb
left a comment
There was a problem hiding this comment.
We already have lowecase keys for all status like "away" instead of "Away" we should update the template that use "Away" for "away" for example.
e311c5b to
390c538
Compare
|
@karlprieb Done 👍 Please review again. Thanks. |
@RocketChat/core
Closes #9547