[FIX] Allow inviting other agents to the same LiveChat room#9903
Closed
renatobecker-zz wants to merge 19 commits intodevelopfrom
Closed
[FIX] Allow inviting other agents to the same LiveChat room#9903renatobecker-zz wants to merge 19 commits intodevelopfrom
renatobecker-zz wants to merge 19 commits intodevelopfrom
Conversation
sampaiodiego
requested changes
Mar 6, 2018
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
I was too deep testing this that I sent a fix for:
using a livechat agent without admin privilegies I was unable tofixed by 70f8833/inviteanother user.
but the following are still changes I would like to be made:
- link to previous chats are not working (still using
code) - there are references to the deprecated
codefield across the code base.
# Conflicts: # server/startup/migrations/v108.js
…etChat/Rocket.Chat into fix-invite-agents-to-livechat-rooms
…etChat/Rocket.Chat into fix-invite-agents-to-livechat-rooms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #9822
Closes #8234
Closes #8235
This fix allows to invite other agents to join the same current chat.
Now, we are using the
_idproperty as a route parameter, instead of using thecodeproperty.So the room link can be shared with other agents.
Additional information:
When a new agent accepts the invitation to participate in a LiveChat room, the visitor will no longer be notified.