[FIX] Rooms list sorting by activity multiple re-renders and case sensitive sorting alphabetically#9959
Merged
sampaiodiego merged 29 commits intodevelopfrom Jun 10, 2018
Merged
[FIX] Rooms list sorting by activity multiple re-renders and case sensitive sorting alphabetically#9959sampaiodiego merged 29 commits intodevelopfrom
sampaiodiego merged 29 commits intodevelopfrom
Conversation
ggazzo
requested review from
karlprieb,
rodrigok and
sampaiodiego
and removed request for
karlprieb
sampaiodiego
requested changes
Mar 23, 2018
Member
There was a problem hiding this comment.
this is not working as expected.. it is showing offline for all users
Member
There was a problem hiding this comment.
did you test with other users or just yours?
| } | ||
| }); | ||
|
|
||
| RocketChat.callbacks.add('enter-room', (sub) => { |
Member
There was a problem hiding this comment.
my channels did not have active indicators while testing
Member
Author
|
|
sampaiodiego
approved these changes
Jun 10, 2018
sampaiodiego
changed the title
Member
Author
|
\o/ |
trongthanh
added a commit
to goalifyplus/Goalify.Chat
that referenced
this pull request
Jun 11, 2018
* develop: (215 commits) [FIX] Rooms list sorting by activity multiple re-renders and case sensitive sorting alphabetically (RocketChat#9959) [FIX] Notification not working for group mentions and not respecting ignored users (RocketChat#11024) fixed searchbar icon and text overlap (RocketChat#10294) [FIX] Link previews not being removed from messages after removed on editing (RocketChat#11063) avoid send presence without loggin Fix: Exception in metrics generation Update release template Update issue templates Update pt-BR.i18n.json LingoHub Update 🚀 update import capnp update build for Sandstorm, add dependence capnp. LingoHub Update 🚀 Fixing HTML on translation files Fixing HTML on translation files LingoHub Update 🚀 Fixing HTML on translation files Fixing HTML on translation files Fixing HTML on translation files LingoHub Update 🚀 ... # Conflicts: # .meteor/packages # README.md # client/startup/startup.js # package-lock.json # packages/rocketchat-error-handler/server/lib/RocketChat.ErrorHandler.js # packages/rocketchat-i18n/i18n/en.i18n.json # packages/rocketchat-i18n/i18n/vi-VN.i18n.json # packages/rocketchat-livechat/config.js # server/startup/initialData.js
trongthanh
added a commit
to goalifyplus/Goalify.Chat
that referenced
this pull request
Jun 11, 2018
* goalify: (217 commits) Add more scripts to reduce mannual interaction during server init [FIX] Rooms list sorting by activity multiple re-renders and case sensitive sorting alphabetically (RocketChat#9959) [FIX] Notification not working for group mentions and not respecting ignored users (RocketChat#11024) fixed searchbar icon and text overlap (RocketChat#10294) [FIX] Link previews not being removed from messages after removed on editing (RocketChat#11063) avoid send presence without loggin Fix: Exception in metrics generation Update release template Update issue templates Update pt-BR.i18n.json LingoHub Update 🚀 update import capnp update build for Sandstorm, add dependence capnp. LingoHub Update 🚀 Fixing HTML on translation files Fixing HTML on translation files LingoHub Update 🚀 Fixing HTML on translation files Fixing HTML on translation files Fixing HTML on translation files ...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #10004
Closes #10415
Closes #9253
Closes #9295
Closes #5341