Skip to content

[NEW] Sorting channels by number of users in directory#9972

Merged
ggazzo merged 5 commits intoRocketChat:developfrom
rooneyg21:bug/directory-filters
Jul 18, 2018
Merged

[NEW] Sorting channels by number of users in directory#9972
ggazzo merged 5 commits intoRocketChat:developfrom
rooneyg21:bug/directory-filters

Conversation

@rooneyg21
Copy link
Contributor

@rooneyg21 rooneyg21 commented Mar 2, 2018

@RocketChat/core

Closes #9817

Sorted by channel name (Default. Working from before)
screen shot 2018-03-02 at 3 21 14 am
Sorted by users in descending order
screen shot 2018-03-02 at 3 22 16 am
Sorted by users in descending order
screen shot 2018-03-02 at 3 22 04 am

TODO:

  • Sort by name when the userCount is the same
  • Add tests

@ggazzo ggazzo added this to the 0.67.0 milestone Jul 3, 2018
@ggazzo ggazzo added the area: ui Touches the code on client side label Jul 3, 2018
ggazzo
ggazzo previously approved these changes Jul 4, 2018
@ggazzo ggazzo changed the title [FIX] [WIP] Sorting channels by number of users in directory [NEW] Sorting channels by number of users in directory Jul 17, 2018
@ggazzo ggazzo merged commit 4441f31 into RocketChat:develop Jul 18, 2018
@theorenck theorenck modified the milestones: 0.67.0, 0.68.0 Jul 19, 2018
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui Touches the code on client side

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discovery sort ui doesnt update

3 participants

Comments