Skip to content

feat(fuselage): New paginated Selects/Options#447

Merged
tiagoevanp merged 12 commits intodevelopfrom
new-paginated-selects
May 18, 2021
Merged

feat(fuselage): New paginated Selects/Options#447
tiagoevanp merged 12 commits intodevelopfrom
new-paginated-selects

Conversation

@MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented May 6, 2021 •
edited
Loading

No description provided.

@MartinSchoeler
Work in progress
ac7ec4f 
Please don't judge my codegueira
@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 7, 2021

This pull request introduces 9 alerts when merging ac7ec4f into 885ba9b - view on LGTM.com

new alerts:

  • 5 for Unused variable, import, function or class
  • 2 for Implicit operand conversion
  • 2 for Use of returnless function

@MartinSchoeler MartinSchoeler marked this pull request as ready for review May 17, 2021 16:45
@MartinSchoeler MartinSchoeler mentioned this pull request May 17, 2021
Merged
@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 17, 2021

This pull request introduces 4 alerts when merging fb1e2ce into f0ede68 - view on LGTM.com

new alerts:

  • 2 for Implicit operand conversion
  • 2 for Use of returnless function

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 17, 2021

This pull request introduces 4 alerts when merging f484dc5 into f0ede68 - view on LGTM.com

new alerts:

  • 2 for Implicit operand conversion
  • 2 for Use of returnless function

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 17, 2021

This pull request introduces 4 alerts when merging 376aca1 into f0ede68 - view on LGTM.com

new alerts:

  • 2 for Implicit operand conversion
  • 2 for Use of returnless function

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 17, 2021

This pull request introduces 4 alerts when merging a8faeb5 into f0ede68 - view on LGTM.com

new alerts:

  • 2 for Implicit operand conversion
  • 2 for Use of returnless function

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 17, 2021

This pull request introduces 4 alerts when merging 62c02f2 into f0ede68 - view on LGTM.com

new alerts:

  • 2 for Implicit operand conversion
  • 2 for Use of returnless function

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 17, 2021

This pull request introduces 4 alerts when merging 7027f91 into f0ede68 - view on LGTM.com

new alerts:

  • 2 for Implicit operand conversion
  • 2 for Use of returnless function

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 17, 2021

This pull request introduces 4 alerts when merging da5dc33 into f0ede68 - view on LGTM.com

new alerts:

  • 2 for Implicit operand conversion
  • 2 for Use of returnless function

tiagoevanp
tiagoevanp suggested changes May 17, 2021
View reviewed changes
Copy link
Contributor

@tiagoevanp tiagoevanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix some margin issues present in .loki files.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 18, 2021

This pull request introduces 4 alerts when merging 3aa3525 into 0046c52 - view on LGTM.com

new alerts:

  • 2 for Implicit operand conversion
  • 2 for Use of returnless function

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 18, 2021

This pull request introduces 4 alerts when merging 5b17ebd into 0046c52 - view on LGTM.com

new alerts:

  • 2 for Implicit operand conversion
  • 2 for Use of returnless function

@tiagoevanp tiagoevanp merged commit 227d7fc into develop May 18, 2021
@tiagoevanp tiagoevanp deleted the new-paginated-selects branch May 18, 2021 00:52
@tiagoevanp tiagoevanp changed the title [WIP] New paginated Selects/Options Feat: New paginated Selects/Options May 18, 2021
@ggazzo ggazzo changed the title Feat: New paginated Selects/Options feat(fuselage): New paginated Selects/Options May 18, 2021
@sampaiodiego sampaiodiego mentioned this pull request May 19, 2021
Merged
@sampaiodiego sampaiodiego mentioned this pull request May 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tiagoevanp tiagoevanp tiagoevanp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MartinSchoeler @tiagoevanp

Comments