Skip to content

Comments

[NEW] Add new icons for omni source channels#597

Closed
murtaza98 wants to merge 3 commits intodevelopfrom
omni/icons
Closed

[NEW] Add new icons for omni source channels#597
murtaza98 wants to merge 3 commits intodevelopfrom
omni/icons

Conversation

@murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Dec 21, 2021

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

@KevLehman
Copy link
Member

I thought the icons would be provided by each app instead of fuselage 🤔

@ggazzo ggazzo added invalid This doesn't seem right wontfix This will not be worked on and removed wontfix This will not be worked on labels Dec 21, 2021
@gabriellsh
Copy link
Member

Yeah, as @KevLehman said, we had discussed previously not to add these icons to fuselage.

@murtaza98 murtaza98 closed this Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants