-
-
Notifications
You must be signed in to change notification settings - Fork 238
Check for optional package requirement: netCDF4 #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks skrobchik! @MrGribel could you please take a look with me, review and then merge it if ready? |
|
I believe we would need to merge this PR into the |
|
@giovaniceotto should I close this PR and open another one or is there a way to change the branch? |
|
@skrobchik You can find an 'edit' button in the upper right corner of the page. If you click it, you will be able to change were you want to merge your commits into. Let me know if you are able to do it or not, ok? |
|
Thank you @lucasfourier |
MrGribel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @skrobchik. We've had been planning on adding it to the default installation as an optional dependency or even migrating away from netCDF4 altogether, but this is as good as it gets for now.
Linter seems to be complaining but I think it's due to it not using the latest version of black during tests, so no worries.

Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Code base maintenance (refactoring, formatting, renaming):
black rocketpy) has passed locally and any fixes were madepytest --runslow) have passed locallyWhat is the current behavior?
When following tutorials, one will run a function which requires an optional dependency "netCDF4". Neither errors nor beginner tutorial communicates that it has to be installed.
What is the new behavior?
Functions that require netCDF4 will now tell that with a comprehensive error message to the user.
Does this introduce a breaking change?