-
-
Notifications
You must be signed in to change notification settings - Fork 238
ENH: change of variables between rocket and motor #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The reference point for the calculation of the center of mass of the motor was altered from the geometric center of the propellant grain to the nozzle
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's indeed a good addition, but as we are requesting a breaking change I believe we should work a little bit more in some files.
Besides to above commentaries I left, I believe we also should adjust the following files to ensure they work well after approving and merging this PR, the adjustments should be short and easy to be done:
- docs\notebooks\getting_started.ipynb
- docs\notebooks\getting_started_colab.ipynb
- docs\notebooks\solid_motor_class_usage.ipynb
- opt*: docs\notebooks\dispersion_analysis\dispersion_analysis.ipynb
distanceNozzlePropellant was changed for distanceNozzleMotorReference. The variables were adjusted in the notebooks.
|
HELP, |
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is fine for me!
Thank you for taking care of every detail on the changed files so we guarantee the code additions are doing great.
And btw congrats for the smart and significant development, looking forward to seeing next PR from you @ompro07 !
The reference point for the calculation of the center of mass of the motor was altered from the geometric center of the propellant grain to the nozzle
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:
ReadMe, Docs and GitHub maintenance:
Code base maintenance (refactoring, formatting, renaming):
black rocketpy) has passed locally and any fixes were madepytest --runslow) have passed locallyCode base additions (for bug fixes / features):
black rocketpy) has passed locally and any fixes were madepytest --runslow) have passed locallyWhat is the current behavior?
Enter text here...
What is the new behavior?
Enter text here...
Does this introduce a breaking change?
Other information
Enter text here...
The reference point for the calculation of the center of mass of the motor was altered from the geometric center of the propellant grain to the nozzle, this will disable the notebooks