Skip to content

Conversation

@Gui-FernandesBR
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • ReadMe, Docs and GitHub maintenance

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

  • ReadMe, Docs and GitHub maintenance:

    • Spelling has been verified
    • Code docs are working correctly

What is the new behavior?

I'm trying to add the following workflows to this setup

  • Auto asign issue or pull request once they are created, by using the author as assignee
  • Automaticallyy add issues am PR to github project once they are opened (this may need testing a little bit more before merging

Does this introduce a breaking change?

  • No

@Gui-FernandesBR Gui-FernandesBR marked this pull request as ready for review August 24, 2022 04:11
@Gui-FernandesBR Gui-FernandesBR self-assigned this Aug 24, 2022
@giovaniceotto
Copy link
Member

Great idea! Have you been able to test if these actions work?

@Gui-FernandesBR
Copy link
Member Author

Great idea! Have you been able to test if these actions work?

I've tested the auto-assingment for issues and pull requests and worked correctly. It assigns the author as assignee (for issues we could re-think that) and the reviewers of PRs are automatically me, giovani and Stano.

For the projects assignment I was not able to test in another public repository. Had some in a private one earlier, but the worst case scenario is that that workflow doesn't work and therefore the issue/task is not added to the project. So in the end of the day would not be bad if it doesn't work on our first try.

Anyway, once we discuss every detail, would you like to merge this before or after the 2022 hackathon? Take in mind that this will assign 3 people as reviewers for every PR, for instance. But of course we could modify the workflow to work properly during hackathon, we could do this in another fork

@Gui-FernandesBR
Copy link
Member Author

Expected behavior:
image

@Gui-FernandesBR Gui-FernandesBR added the C.I. Continuous Integration (Workflows and actions) label Sep 10, 2022
@Gui-FernandesBR
Copy link
Member Author

@giovaniceotto @MateusStano @PatrickSampaioUSP , I'm asking review from one of you.

Can we proceed with approving/merging?

Everything should be working now.

@giovaniceotto giovaniceotto removed their request for review September 10, 2022 17:13
@giovaniceotto
Copy link
Member

@PatrickSampaioUSP is better suited to review this one. I'll add him as soon as he accepts the invite to participate in this repo.

@giovaniceotto giovaniceotto requested review from PatrickSampaioUSP and removed request for MateusStano September 10, 2022 17:17
@giovaniceotto
Copy link
Member

Added @PatrickSampaioUSP as a reviewer.

Copy link
Contributor

@PatrickSampaioUSP PatrickSampaioUSP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, we should merge it and test

@Gui-FernandesBR Gui-FernandesBR merged commit 80f84da into master Sep 13, 2022
@Gui-FernandesBR
Copy link
Member Author

Idk why but this not worked when Franz opened the last PR

@Gui-FernandesBR Gui-FernandesBR deleted the MAINT/autoassign_workflows branch September 21, 2022 06:51
@giovaniceotto
Copy link
Member

Still not working, right?

@Gui-FernandesBR
Copy link
Member Author

Still not working, right?

Perfectly, not yet, but it already worked on some cases.
I'm still investigating.

For sure, the 'auto-assign to project' is definetely not working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C.I. Continuous Integration (Workflows and actions)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants