-
-
Notifications
You must be signed in to change notification settings - Fork 237
Fix: Cached Property support for Python 3.6 and 3.7 #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d24fce7
ENH: created a cached_property decorator
giovaniceotto d7a8e60
FIX: import local cached_property if standard does not exist
giovaniceotto b81e30f
ENH: Prevents cached_property decorator from being used before `__set…
giovaniceotto a46aa2e
Fix code style issues with Black
lint-action File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| _NOT_FOUND = object() | ||
|
|
||
|
|
||
| class cached_property: | ||
| def __init__(self, func): | ||
| self.func = func | ||
| self.attrname = None | ||
| self.__doc__ = func.__doc__ | ||
|
|
||
| def __set_name__(self, owner, name): | ||
| self.attrname = name | ||
|
|
||
| def __get__(self, instance, owner=None): | ||
| if instance is None: | ||
| return self | ||
| if self.attrname is None: | ||
| raise TypeError( | ||
| "Cannot use cached_property instance without calling __set_name__ on it." | ||
| ) | ||
| cache = instance.__dict__ | ||
giovaniceotto marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| val = cache.get(self.attrname, _NOT_FOUND) | ||
| if val is _NOT_FOUND: | ||
| val = self.func(instance) | ||
| cache[self.attrname] = val | ||
| return val | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.