DOC: fix Getting Started notebooks Dynamic Analysis section #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@Gui-FernandesBR, please consider the importance of us merging this PR fast since the latest documentation is wrong. |
Member
|
Shall we use %matplotlib inline instead of widget? This way the plots are rendered in docs section, wllowing us to see what is being shown to be readers |
Member
|
https://docs.rocketpy.org/en/latest/notebooks/getting_started.html It is still using |
Member
Author
|
@Gui-FernandesBR, I believe the problem of not showing the plots is more related to ReadTheDocs/Sphinx. Here on GitHub, they do render correctly. We can investigate this in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:
ReadMe, Docs and GitHub maintenance:
What is the current behavior?
As reported in #292, the Dynamic Stability Analysis section of the Getting Started Notebook is not working as expected:
What is the new behavior?
The problem was that the variable
factorwas not being used inside the for loop. This has been fixed:Does this introduce a breaking change?
Other information
Should be merged directly into master since it is not related to the core code, but to the documentation. Once merged, the documentation will be updated automatically.