ENH: Liquid Motors Updates #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phmbressan
added
Enhancement
giovaniceotto
approved these changes
Nov 22, 2022
Member
|
Great improvements! Everything looks good. The only problems I see are related to the new coordinate system. However, this cannot be properly dealt with until #282 is merged. I will merge this to the liquid motor branch where we can fine tune the integration details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:
Code base additions (for bug fixes / features):
black rocketpy) has passed locally and any fixes were madepytest --runslow) have passed locallyWhat is the current behavior?
LiquidMotorclass lacks inertia tensor implementation and does not have complete docstrings.What is the new behavior?
The
LiquidMotorclass now calculates the inertia tensor from each of its tanks inertia. Furthermore, docstrings were added and updated when necessary, along with minor fixes in__init__.Does this introduce a breaking change?