Skip to content

Conversation

@MateusStano
Copy link
Member

Pull request checklist

  • Tests for the changes have been added
  • Docs have been reviewed and added / updated if needed
  • Lint (black rocketpy) has passed locally and any fixes were made
  • All tests (pytest --runslow) have passed locally

What is the new?

snake_case!

Does this introduce a breaking change?

  • Yes
  • No

Other information

Enter text here...

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@MateusStano MateusStano changed the base branch from master to beta/v1.0.0 May 4, 2023 16:43
@MateusStano MateusStano self-assigned this May 4, 2023
@MateusStano MateusStano added this to the Release v1.0.0 milestone May 4, 2023
@Gui-FernandesBR Gui-FernandesBR mentioned this pull request May 27, 2023
5 tasks
Gui-FernandesBR and others added 6 commits June 29, 2023 05:03
- Merge branch 'beta/v1.0.0' into enh/snake-case
- Apply snake_case to motors module
- Finish notebooks and ensure everything is running

Co-authored-by: phmbressan <phmbressan@users.noreply.github.com>
@Gui-FernandesBR Gui-FernandesBR marked this pull request as ready for review July 1, 2023 01:54
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well_done_stano_i_really_loved_this_pr_many_thanks

Copy link
Collaborator

@phmbressan phmbressan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, great to see the code much more consistent now.

@Gui-FernandesBR Gui-FernandesBR merged commit 0f961bf into beta/v1.0.0 Jul 1, 2023
@Gui-FernandesBR Gui-FernandesBR deleted the enh/snake-case branch July 4, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants