Skip to content

FIX: optional imports for EnvironmentAnalysis prevent default install. #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phmbressan wants to merge 1 commit into from
Closed

FIX: optional imports for EnvironmentAnalysis prevent default install. #399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions rocketpy/EnvironmentAnalysis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,6 @@
from rocketpy.Environment import Environment
from rocketpy.Function import Function
from rocketpy.units import convert_units

try:
import ipywidgets as widgets
import jsonpickle
from timezonefinder import TimezoneFinder
from windrose import WindroseAxes
except ImportError as error:
raise ImportError(
f"The following error was encountered while importing dependencies: '{error}'. "
"Please note that the EnvironmentAnalysis requires additional dependencies, "
"which can be installed by running 'pip install rocketpy[env_analysis]'."
)
from .plots.environment_analysis_plots import _EnvironmentAnalysisPlots
from .prints.environment_analysis_prints import _EnvironmentAnalysisPrints
from .tools import (
Expand Down Expand Up @@ -180,7 +168,19 @@ def __init__(
-------
None
"""

# Import optional modules
try:
import ipywidgets as widgets
import jsonpickle
from timezonefinder import TimezoneFinder
from windrose import WindroseAxes
except ImportError as error:
raise ImportError(
"The following error was encountered while importing dependencies: "
f"{error}. Please note that the EnvironmentAnalysis requires additional "
"dependencies, which can be installed by running 'pip install "
"rocketpy[env_analysis]'."
)
# Save inputs
self.start_date = start_date
self.end_date = end_date
Expand Down