Skip to content

Conversation

@Gui-FernandesBR
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Code base additions (bugfix, features)

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

  • Code base additions (for bug fixes / features):

    • Tests for the changes have been added
    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally

What is the current behavior?

You give an airfoil curve as input, but RocketPy do not let you to check if the curve is correct.

What is the new behavior?

A few more plots or prints were added to improve the visualization of airfoil data when it is used.
This closes #144

Does this introduce a breaking change?

  • No

Other information

Easy to review.

@github-actions github-actions bot requested a review from MateusStano September 3, 2023 02:35
@Gui-FernandesBR Gui-FernandesBR linked an issue Sep 3, 2023 that may be closed by this pull request
Copy link
Collaborator

@phmbressan phmbressan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR, solves an old issue.

@Gui-FernandesBR
Copy link
Member Author

The previous naming is not that good, but its there just to differentiate clalpha2D_mach0 form clalpha2D

Please check the last version of the code (screenshot below).

I believe the clalpha2D_incompressible is a clearer name for such variable.
Also, I refactor the code bit so the beta correction is called just once.

image

@Gui-FernandesBR Gui-FernandesBR merged commit 335998f into beta/v1.0.0 Sep 8, 2023
@Gui-FernandesBR Gui-FernandesBR deleted the enh/airfoil-outputs branch September 8, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Airfoil Rocket.allInfo() method

4 participants