Skip to content

Conversation

@Gui-FernandesBR
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR commented Jul 6, 2024

Pull request type

  • Other (please describe): Tests and linters

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

I didn't pylint the tests module earlier because @lucasfourier was refactoring the tests. Now I can finally apply pylint for tests!

New behavior

Now we are going to see pylint and flake8 warning in the tests module as well!

Breaking change

  • No

Additional information

@Gui-FernandesBR Gui-FernandesBR added Tests Regarding Tests C.I. Continuous Integration (Workflows and actions) Refactor labels Jul 6, 2024
@Gui-FernandesBR Gui-FernandesBR self-assigned this Jul 6, 2024
@Gui-FernandesBR Gui-FernandesBR requested a review from a team as a code owner July 6, 2024 03:51
@Gui-FernandesBR Gui-FernandesBR changed the base branch from dev/adds-flake8-as-pylint-fallback to develop July 6, 2024 03:56
@Gui-FernandesBR Gui-FernandesBR force-pushed the mnt/pylint-tests-module branch from b533722 to 0d01bf0 Compare July 6, 2024 04:11
@codecov
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.85%. Comparing base (fd4941c) to head (44cd770).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #632      +/-   ##
===========================================
- Coverage    73.92%   73.85%   -0.08%     
===========================================
  Files           70       70              
  Lines        10032    10035       +3     
===========================================
- Hits          7416     7411       -5     
- Misses        2616     2624       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gui-FernandesBR Gui-FernandesBR force-pushed the mnt/pylint-tests-module branch from 502b991 to b8ae06a Compare July 6, 2024 17:16
Copy link
Member

@MateusStano MateusStano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

I really like the grouping of tests into Classes

@Gui-FernandesBR Gui-FernandesBR merged commit 758f29d into develop Jul 9, 2024
@Gui-FernandesBR Gui-FernandesBR deleted the mnt/pylint-tests-module branch July 9, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C.I. Continuous Integration (Workflows and actions) Refactor Tests Regarding Tests

Projects

No open projects
Status: Closed

Development

Successfully merging this pull request may close these issues.

3 participants