ENH: Fix Orientation Param of Inertial Sensors #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gui-FernandesBR
force-pushed
the
enh/fix-orientation-sensors
branch
from
9b0f15d to
18a99a7
Compare
Gui-FernandesBR
approved these changes
Sep 14, 2024
Member
Gui-FernandesBR
left a comment
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Can be merged once the tests get concluded.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #688 +/- ##
===========================================
- Coverage 75.42% 75.40% -0.03%
===========================================
Files 96 96
Lines 10841 10832 -9
===========================================
- Hits 8177 8168 -9
Misses 2664 2664 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptiom
Small change to
orientationparam of theInertialSensorclass due to changes in the rocket axes definitions from #635The rotation has been changed from 3-2-1 to 3-1-3 for ease of use