DOC: Generic Surface #690
Merged
DOC: Generic Surface #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/user/rocket/generic_surface.rst
Outdated
| rocket = Rocket( | ||
| ... | ||
| ) | ||
| rocket.add_generic_surface(generic_surface, position=(0,0,0)) |
Member
There was a problem hiding this comment.
Mmmmmm do we really need a add_generic_surface method? Why not using the very same add_surfaces method?
Gui-FernandesBR
approved these changes
Sep 14, 2024
Member
Gui-FernandesBR
left a comment
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
There's a file mistakenlly added to the tests/fixtures/motor folder, can you please delete it?
Btw your new documentation is really cool, I think we have been mastering sphinx documentation on RocketPy for a while now.
Gui-FernandesBR
force-pushed
the
enh/generic-surfaces-pylint
branch
from
ce68698 to
e45dc11
Compare
Gui-FernandesBR
force-pushed
the
enh/generic-surfaces-pylint
branch
from
40a9cf8 to
c7a4179
Compare
Base automatically changed from
enh/generic-surfaces-pylint
to
enh/generic-surfaces
September 14, 2024 22:12
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## enh/generic-surfaces #690 +/- ##
========================================================
+ Coverage 74.85% 74.89% +0.04%
========================================================
Files 98 98
Lines 11012 11006 -6
========================================================
Hits 8243 8243
+ Misses 2769 2763 -6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Description
Added docs page describing usage of the GenericSurface classes
Added
GenericSurfaceandLinearGenericSurfacedoc strings to reference docs