Skip to content

Conversation

@Lucas-Prates
Copy link
Contributor

@Lucas-Prates Lucas-Prates commented Sep 17, 2024

Pull request type

  • Code maintenance (refactoring, formatting, tests)

Checklist

  • Tests for the changes have been added (if needed)
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

No tests.

New behavior

Unit tests for generic surfaces

Breaking change

  • Yes
  • No

Tasks

  • Unit test for GenericSurfaces (97% coverage)
  • Use tmpdir_factory to automatically clean up created CSV files
  • Unit test for LinearGenericSurfaces

@Lucas-Prates Lucas-Prates requested a review from a team as a code owner September 17, 2024 01:03
@Lucas-Prates Lucas-Prates self-assigned this Sep 17, 2024
Copy link
Member

@MateusStano MateusStano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good with the GenericSurfaces tests

I think we still need similar tests for LinearGenericSurfaces

The integration tests are low priority for now, so we can leave it for later if need

@Lucas-Prates
Copy link
Contributor Author

Everything seems good with the GenericSurfaces tests

I think we still need similar tests for LinearGenericSurfaces

The integration tests are low priority for now, so we can leave it for later if need

Added tests for LinearGenericSurfaces with 100% coverage. I got an unexpected behavior of division by zero. I explained the issue in the #680 PR.

@MateusStano MateusStano merged commit da38b2a into enh/generic-surfaces Sep 20, 2024
@MateusStano MateusStano deleted the tst/generic-surfaces branch September 20, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Closed

Development

Successfully merging this pull request may close these issues.

3 participants