Skip to content

BUG: Vector encoding breaks MonteCarlo export. #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gui-FernandesBR merged 3 commits into from
Oct 9, 2024
Merged

BUG: Vector encoding breaks MonteCarlo export. #704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af5e99b
BUG: Vector encoding breaks MonteCarlo export.
phmbressan Oct 7, 2024
97b7734
MNT: add changes to CHANGELOG.
phmbressan Oct 7, 2024
4be37e4
ENH: make the Matrix class JSON serializable
Gui-FernandesBR Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Attention: The newest changes should be on top -->

### Fixed

-
- BUG: Vector encoding breaks MonteCarlo export. [#704](https://github.com/RocketPy-Team/RocketPy/pull/704)

## [v1.6.0] - 2024-09-29

Expand Down
8 changes: 8 additions & 0 deletions rocketpy/mathutils/vector_matrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,10 @@ def k():
"""Returns the k vector, [0, 0, 1]."""
return Vector([0, 0, 1])

def to_dict(self):
"""Returns the vector as a JSON compatible element."""
return list(self.components)


class Matrix:
"""Pure Python 3x3 Matrix class for simple matrix-matrix and matrix-vector
Expand Down Expand Up @@ -998,6 +1002,10 @@ def __repr__(self):
+ f" [{self.zx}, {self.zy}, {self.zz}])"
)

def to_dict(self):
"""Returns the matrix as a JSON compatible element."""
return [list(row) for row in self.components]

@staticmethod
def identity():
"""Returns the 3x3 identity matrix."""
Expand Down