Skip to content

BUG: Fix Motor Zero Dry Mass Check #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phmbressan merged 2 commits into from
Oct 9, 2024
Merged

BUG: Fix Motor Zero Dry Mass Check #710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4947ced
BUG: fix zero mass check
laurapgp Oct 9, 2024
eb3ad14
MNT: Add bug zero dry mass bug fix to CHANGELOG.
phmbressan Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ Attention: The newest changes should be on top -->

### Fixed

- BUG: Fix Motor Zero Dry Mass Check [#710](https://github.com/RocketPy-Team/RocketPy/pull/710)
- BUG: Fix Environment.max_expected_height for custom atmosphere [#707](https://github.com/RocketPy-Team/RocketPy/pull/707)
- BUG: Initialize _Controller Init Parameters [#703](https://github.com/RocketPy-Team/RocketPy/pull/703)
- BUG: Rail Buttons Not Accepted in Add Surfaces [#701](https://github.com/RocketPy-Team/RocketPy/pull/701)
Expand Down
2 changes: 1 addition & 1 deletion rocketpy/motors/motor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ def dry_mass(self, dry_mass):
dry_mass : float
Motor dry mass in kg.
"""
if dry_mass:
if dry_mass is not None:
if isinstance(dry_mass, (int, float)):
self._dry_mass = dry_mass
else:
Expand Down