Skip to content

ENH: Implement Multivariate Rejection Sampling (MRS) #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lucas-Prates merged 20 commits into from
Apr 12, 2025

Merge branch 'develop' into enh/MRS

3530eed
Select commit
Loading
Failed to load commit list.
Merged

ENH: Implement Multivariate Rejection Sampling (MRS) #738

Merge branch 'develop' into enh/MRS
3530eed
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 12, 2025 in 0s

79.76% (+0.64%) compared to 4df0b38

View this Pull Request on Codecov

79.76% (+0.64%) compared to 4df0b38

Details

Codecov Report

Attention: Patch coverage is 82.80543% with 38 lines in your changes missing coverage. Please review.

Project coverage is 79.76%. Comparing base (4df0b38) to head (3530eed).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
rocketpy/plots/monte_carlo_plots.py 80.00% 16 Missing ⚠️
rocketpy/prints/monte_carlo_prints.py 57.69% 11 Missing ⚠️
...ketpy/simulation/multivariate_rejection_sampler.py 89.81% 11 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #738      +/-   ##
===========================================
+ Coverage    79.11%   79.76%   +0.64%     
===========================================
  Files           96       97       +1     
  Lines        11575    11877     +302     
===========================================
+ Hits          9158     9474     +316     
+ Misses        2417     2403      -14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov