Skip to content

DEV: Updates master for v1.7.1 #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phmbressan merged 5 commits into from
Dec 7, 2024
Merged

DEV: Updates master for v1.7.1 #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d93666a
MNT: Refactor Tank's testing Assertion with CAD data. (#678)
phmbressan Nov 30, 2024
396b122
BUG: Correctly update atmospheric conditions after changing date and …
WilliamArmst Dec 2, 2024
cb25bad
Apply suggestions from code review
WilliamArmst Dec 2, 2024
cf98bb3
fix date and location atmosphere update formatting
WilliamArmst Dec 3, 2024
ed2a6a2
Merge pull request #743 from WilliamArmst/develop
phmbressan Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@
"polystyle",
"powerseries",
"Prandtl",
"pressurant",
"prettytable",
"Projeto",
"prometheus",
Expand Down Expand Up @@ -265,6 +266,7 @@
"SBMT",
"scilimits",
"searchsorted",
"seblm",
"seealso",
"setrail",
"simplekml",
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,12 @@ Attention: The newest changes should be on top -->

### Changed

- MNT: Refactor Tank's testing Assertion with CAD data. [#678](https://github.com/RocketPy-Team/RocketPy/pull/678)

### Fixed

- BUG: Correctly update atmospheric conditions after changing date and location [#743](https://github.com/RocketPy-Team/RocketPy/pull/743)


## [v1.7.0] - 2024-11-30

Expand Down
8 changes: 6 additions & 2 deletions rocketpy/environment/environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,9 @@ def set_date(self, date, timezone="UTC"):
"Ensemble",
]:
self.set_atmospheric_model(
self.atmospheric_model_file, self.atmospheric_model_dict
type=self.atmospheric_model_type,
file=self.atmospheric_model_file,
dictionary=self.atmospheric_model_dict,
)

def set_location(self, latitude, longitude):
Expand Down Expand Up @@ -726,7 +728,9 @@ def set_location(self, latitude, longitude):
"Ensemble",
]:
self.set_atmospheric_model(
self.atmospheric_model_file, self.atmospheric_model_dict
type=self.atmospheric_model_type,
file=self.atmospheric_model_file,
dictionary=self.atmospheric_model_dict,
)

def set_gravity_model(self, gravity=None):
Expand Down
Loading
Loading