Skip to content

Bug: Fix StochasticFlight time_overshoot None bug #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MateusStano merged 2 commits into from
Apr 21, 2025
Merged

Bug: Fix StochasticFlight time_overshoot None bug #805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ba5a7d
BUG: fix parachute bug by setting time_overshoot to base flight when …
Lucas-Prates Apr 18, 2025
9a52185
MNT: update changelog
Lucas-Prates Apr 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ Attention: The newest changes should be on top -->

### Added

- BUG: Fix StochasticFlight time_overshoot None bug [#805] (https://github.com/RocketPy-Team/RocketPy/pull/805)
- ENH: Implement Multivariate Rejection Sampling (MRS) [#738] (https://github.com/RocketPy-Team/RocketPy/pull/738)
- ENH: Create a rocketpy file to store flight simulations [#800](https://github.com/RocketPy-Team/RocketPy/pull/800)
- ENH: Support for the RSE file format has been added to the library [#798](https://github.com/RocketPy-Team/RocketPy/pull/798)
Expand Down
5 changes: 4 additions & 1 deletion rocketpy/stochastic/stochastic_flight.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,10 @@ def __init__(

self.initial_solution = initial_solution
self.terminate_on_apogee = terminate_on_apogee
self.time_overshoot = time_overshoot
if time_overshoot is None:
self.time_overshoot = flight.time_overshoot
else:
self.time_overshoot = time_overshoot

def _validate_initial_solution(self, initial_solution):
if initial_solution is not None:
Expand Down
Loading