Skip to content

Conversation

@cazzopardi
Copy link
Contributor

@cazzopardi cazzopardi commented Jul 12, 2025

Pull request type

  • Code changes (bugfix, features)

Checklist

  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

The StochasticNoseCone class does not support "powerseries" nose cones (issue #838 )

New behavior

Closes issue #838 by adding the power parameter the constructor of StochasticNoseCone

Breaking change

  • No

Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from Backlog to Next Version in LibDev Roadmap Jul 14, 2025
@codecov
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.03%. Comparing base (f17893b) to head (5de3ee7).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #839      +/-   ##
===========================================
+ Coverage    80.02%   80.03%   +0.01%     
===========================================
  Files           98       98              
  Lines        12004    12021      +17     
===========================================
+ Hits          9606     9621      +15     
- Misses        2398     2400       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Gui-FernandesBR Gui-FernandesBR force-pushed the bug/fix_stochastic_nose_cone_powerseries_issue_838 branch from 899c340 to 5de3ee7 Compare July 25, 2025 01:24
@Gui-FernandesBR Gui-FernandesBR merged commit 75b8e5f into RocketPy-Team:develop Jul 25, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Next Version to Closed in LibDev Roadmap Jul 25, 2025
@cazzopardi cazzopardi deleted the bug/fix_stochastic_nose_cone_powerseries_issue_838 branch January 6, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Closed

Development

Successfully merging this pull request may close these issues.

2 participants