Fix disassembler tracing early exits with some LD instructions#15
Merged
Rodrigodd merged 2 commits intoRodrigodd:masterfrom Dec 24, 2024
Merged
Conversation
This doesn't do anything at all. It just makes the code harder to understand.
Owner
|
Thanks! I believe that is the correct solution. The code is trying to detect if a bank switch happens at that instruction, but the value is unknown so is uncertain if that will happen or not. But other parts of the code already makes the assumption that a program will very unlikely change the bank under itself, so this fix is fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This took a long time to track down. I'm not entirely certain what the real solution should be, but this seems to fix it.
These screenshots show the problem. The disassembly prematurely ends at an LD instruction:
I found the problem was that
Nonewas being returned as the firstCursorfor this specific instruction pattern.While tracking this down, I also noticed a bizarre use of
RefCellthat isn't needed. So I removed that in a second commit.