This repository was archived by the owner on Dec 3, 2023. It is now read-only.
Update thread-safe implementation for GameFiles#1
Open
nguyenlamlll wants to merge 1 commit intoRonenNess:masterfrom
Open
Update thread-safe implementation for GameFiles#1nguyenlamlll wants to merge 1 commit intoRonenNess:masterfrom
nguyenlamlll wants to merge 1 commit intoRonenNess:masterfrom
Conversation
Locking on the value of a private static variable to prevent thread-safety violations and performance issues.
Owner
|
I'll take a look when I'll have time, probably during the next weekend.. |
Owner
|
OK overall this seems like an harmless change, but could you explain a bit what problem it solves and how is this improving performance? Thanks! |
Author
|
I haven't looked at the full engine yet but so far what I've found and based on what I've experienced, the previous version implemented a non-safe singleton pattern. We may try to multi-thread saving some game files in the future so these changes ensure that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locking on the value of a private static variable to prevent thread-safety violations and performance issues.