feat: add telemetry error capture to Mistral provider #10112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Import TelemetryService and ApiProviderError - Add providerName property to MistralHandler class - Wrap createMessage() client.chat.stream() call in try/catch with telemetry capture - Add telemetry capture in completePrompt() catch block - Add tests to verify telemetry is called on error for both methods Follows the pattern established in PR #10073 for OpenRouter provider.
dosubot
bot
added
the
size:M
Contributor
Review complete. No issues found. The implementation correctly adds telemetry error capture to the Mistral provider, following the pattern established in PR #10073 for OpenRouter. The changes are well-tested with comprehensive coverage for both Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
Member
Author
|
Closing - changes will be added to PR #10059 instead |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| const errorMessage = error instanceof Error ? error.message : String(error) | ||
| const apiError = new ApiProviderError(errorMessage, this.providerName, model, "createMessage") | ||
| TelemetryService.instance.captureException(apiError) | ||
| throw new Error(`Mistral completion error: ${errorMessage}`) |
Contributor
There was a problem hiding this comment.
Consider preserving the original error’s stack trace by attaching the caught error as a cause when rethrowing (e.g. using the { cause: error } option) to provide better debugging context.
Suggested change
| throw new Error(`Mistral completion error: ${errorMessage}`) | |
| throw new Error(`Mistral completion error: ${errorMessage}`, { cause: error }) |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds telemetry error capture to the Mistral provider, following the pattern established in PR #10073 for OpenRouter.
Changes
TelemetryServicefrom@roo-code/telemetryApiProviderErrorfrom@roo-code/typesproviderNameproperty toMistralHandlerclasscreateMessage()client.chat.stream()call in try/catch with telemetry capturecompletePrompt()catch blockRelated
Follows the pattern established in PR #10073 for OpenRouter provider.
Testing
mistral.spec.tspassshould capture telemetry exception on createMessage errorshould capture telemetry exception on completePrompt errorImportant
Add telemetry error capture to Mistral provider's
createMessageandcompletePromptmethods with tests for error handling.createMessage()andcompletePrompt()methods inmistral.tsusingTelemetryService.client.chat.stream()andclient.chat.complete()calls in try/catch blocks to capture exceptions.TelemetryServicefrom@roo-code/telemetry.ApiProviderErrorfrom@roo-code/types.mistral.spec.tsto verify telemetry is called on errors increateMessageandcompletePromptmethods.TelemetryServiceto capture exceptions in tests.This description was created by
for cf5c75d. You can customize this summary. It will automatically update as commits are pushed.