Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Dec 16, 2025

Fixes the error details dialog to show full error information (including stack traces) when streaming failures occur.

Changes

  • Pass apiReqStreamingFailedMessage to the errorDetails prop of ErrorRow component
  • This enables the info button and modal dialog to display the complete error context that was previously only logged to console

Problem

When API streaming failed, users would see a generic error message in the chat UI, but the detailed error information (error message, stack trace, modelId, taskId) was only logged to the console. The error details dialog introduced in #10050 was not receiving this information.

Solution

Updated ChatRow.tsx to pass the streaming failure message to the errorDetails prop, which triggers the display of the info icon and allows users to view and copy the full error details.

Testing

  • Type checking passes
  • Linting passes
  • No tests exist for ErrorRow component

View task on Roo Code Cloud


Note

Enable full streaming error details in chat UI and unify retry backoff handling by simplifying backoffAndAnnounce and its call sites.

  • UI (webview):
    • ChatRow.tsx: Pass apiReqStreamingFailedMessage to ErrorRow via errorDetails, enabling full error detail dialog for streaming failures.
  • Core (Task handling):
    • Standardize retry backoff: backoffAndAnnounce now derives header text from error (removed header arg); update all call sites (first‑chunk, mid‑stream, empty‑response retries).
    • Minor cleanups: remove unused state reads, simplify object literals, small guard/brace tweaks.

Written by Cursor Bugbot for commit 4e0861f. This will update automatically on new commits. Configure here.


Important

Enhance error visibility in chat UI by passing detailed error messages to ErrorRow in ChatRow.tsx and clean up unused code in Task.ts.

  • Behavior:
    • Pass apiReqStreamingFailedMessage to errorDetails prop of ErrorRow in ChatRow.tsx to display full error context in the UI.
    • Enables info button and modal dialog to show complete error details, previously only logged to console.
  • Code Cleanup:
    • Remove unused state variable in Task.ts.
    • Simplify backoffAndAnnounce() calls in Task.ts by removing streamingFailedMessage parameter.
    • Remove redundant didEndLoop variable in Task.ts.

This description was created by Ellipsis for 4e0861f. You can customize this summary. It will automatically update as commits are pushed.

@roomote
Copy link
Contributor Author

roomote bot commented Dec 16, 2025

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

The latest commit (4e0861f) contains minor cleanup changes to Task.ts: removing unused variables, simplifying the backoffAndAnnounce method signature, and consolidating error message construction. All changes are safe code improvements with no functional regressions.

Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 16, 2025
@cte cte marked this pull request as ready for review December 16, 2025 18:21
@cte cte requested review from cte, jr and mrubens as code owners December 16, 2025 18:21
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 16, 2025
@dosubot dosubot bot added lgtm This PR has been approved by a maintainer Enhancement New feature or request labels Dec 16, 2025
@roomote
Copy link
Contributor Author

roomote bot commented Dec 16, 2025

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

The changes correctly:

  • Pass apiReqStreamingFailedMessage to the errorDetails prop of ErrorRow, enabling the error details dialog for streaming failures
  • Clean up unused code in Task.ts (removed unused state variable)
  • Simplify backoffAndAnnounce by deriving header text from the error object itself
  • Update all call sites consistently

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@cte cte merged commit caf6142 into main Dec 16, 2025
27 checks passed
@cte cte deleted the fix/add-streaming-error-details-to-dialog branch December 16, 2025 18:34
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Dec 16, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Dec 16, 2025
@cte cte mentioned this pull request Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants