fix(openai): remove convertToSimpleMessages to fix tool calling for OpenAI-compatible providers #10575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…penAI-compatible providers Removes the convertToSimpleMessages function which was converting tool_use blocks to text like '[Tool Use: write_to_file]' instead of proper OpenAI tool_calls format. This caused models to output text mimicking tool calls instead of actually invoking tools, triggering errors like 'The model provided text/reasoning but did not call any of the required tools.' Root cause: convertToSimpleMessages was added for Volcano Ark compatibility when tools weren't being sent. After v3.37.1 added NATIVE_TOOL_DEFAULTS, tools were always sent but history showed text patterns, confusing models. Changes: - Remove convertToSimpleMessages usage from openai.ts - Delete simple-format.ts and its tests - Remove openAiLegacyFormat setting from provider-settings schema - Remove legacy format checkbox from OpenAI Compatible settings UI - Remove useLegacyFormat translation key from all locales Fixes ROO-433
dosubot
bot
added
size:L
Contributor
Review complete. No issues found. The PR correctly removes deprecated Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
mrubens
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
convertToSimpleMessagesfunction which was convertingtool_useblocks to text like[Tool Use: write_to_file]instead of proper OpenAItool_callsformat.This caused models to output text mimicking tool calls instead of actually invoking tools, triggering errors like:
Root Cause
convertToSimpleMessageswas added in Feb 2025 for Volcano Ark (.volces.com) compatibility when tools weren't being sent. After v3.37.1 addedNATIVE_TOOL_DEFAULTS, tools were always sent but history showed text patterns, confusing models.Changes
convertToSimpleMessagesusage fromopenai.tssimple-format.tsand its testsopenAiLegacyFormatsetting from provider-settings schemauseLegacyFormattranslation key from all 18 localesTesting
Fixes ROO-433
Important
Remove
convertToSimpleMessagesto fix tool call issues for OpenAI-compatible providers, affecting settings and localization.convertToSimpleMessagesfromopenai.ts, fixing tool call issues for OpenAI-compatible providers.simple-format.tsand its tests.openAiLegacyFormatfrom provider-settings schema.useLegacyFormattranslation key from all 18 locales.This description was created by
for 5c3b910. You can customize this summary. It will automatically update as commits are pushed.