Skip to content

Conversation

@sebastiand-cerebras
Copy link
Contributor

@sebastiand-cerebras sebastiand-cerebras commented Jan 24, 2026

Added supportsTemperature: true, defaultTemperature: 0.9 to zai-glm-4.7 model + changeset

Similar to packages/types/src/providers/moonshot.ts:

supportsTemperature: true, // Default temperature: 1.0
preserveReasoning: true,
defaultTemperature: 1.0,

Important

Add temperature support with default 1.0 to zai-glm-4.7 model in cerebras.ts.

  • Behavior:
    • Adds supportsTemperature: true and defaultTemperature: 1.0 to zai-glm-4.7 model in cerebras.ts.
  • Documentation:
    • Adds .changeset/glm-47-temperature.md to document the default temperature setting for zai-glm-4.7.

This description was created by Ellipsis for b2dba30. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Enhancement New feature or request labels Jan 24, 2026
@roomote
Copy link
Contributor

roomote bot commented Jan 24, 2026

Rooviewer Clock   See task on Roo Cloud

Review complete. No code issues found. The code changes in cerebras.ts are valid and correctly typed.

Note: The changeset file was deleted in the latest commit. The PR title mentions "temperature=0.9 and top_p=0.95" but the actual implementation sets defaultTemperature: 1.0 with no top_p field (which doesn't exist in the schema).

Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

2 participants