Skip to content

Conversation

@vikaschib7
Copy link

Related GitHub Issue

Closes: #

Roo Code Task Context (Optional)

Description

Test Procedure

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch

@vikaschib7 vikaschib7 requested a review from mrubens as a code owner January 25, 2026 00:08
@vikaschib7 vikaschib7 requested review from cte and jr as code owners January 25, 2026 00:08
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. Enhancement New feature or request labels Jan 25, 2026
@roomote
Copy link
Contributor

roomote bot commented Jan 25, 2026

Rooviewer Clock   Follow along on Roo Cloud

Reviewing your PR now. I'll share feedback in a few minutes!

@vikaschib7 vikaschib7 marked this pull request as draft January 25, 2026 00:10
@vikaschib7 vikaschib7 closed this Jan 25, 2026
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jan 25, 2026
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jan 25, 2026
@ellipsis-dev
Copy link
Contributor

ellipsis-dev bot commented Jan 25, 2026

⚠️ This PR is too big for Ellipsis, but support for larger PRs is coming soon. If you want us to prioritize this feature, let us know at help@ellipsis.dev


Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review: Request Changes

This PR cannot be merged in its current state due to several critical issues:

1. Inappropriate Rebranding (Blocker)

This PR includes extensive rebranding from "Roo Code" to "s2sCopilot" which is not appropriate for an upstream contribution. The following files contain rebranding changes that must be removed:

  • .roomodes - Replaces "Roo" with "s2sCopilot" in all custom mode role definitions
  • PRIVACY.md - Renames "Roo Code Privacy Policy" to "s2sCopilot Privacy Policy"
  • README.md - Project documentation rebranding
  • All 18 localization files (src/i18n/locales/*/common.json)
  • All 19 package NLS files (src/package.nls.*.json)

2. Large Files Should Not Be Committed (Blocker)

The following files are inappropriate for the repository:

  • ca-bundle.crt (~6500+ lines) - A massive CA certificate bundle should NOT be committed to the repository. Enterprise CA certificates should be configured via system trust stores or environment variables, not bundled in source code.
  • rename.png - Screenshot file that should not be in the repo
  • s2sCopilot.jpg - Branding image that should not be committed

3. Icon/Asset Replacements (Blocker)

The PR replaces Roo Code branding assets with s2sCopilot branding:

  • src/assets/icons/icon-nightly.png
  • src/assets/icons/icon.png
  • src/assets/icons/icon.svg
  • src/assets/icons/panel_dark.png
  • src/assets/icons/panel_light.png
  • src/assets/images/roo-logo.svg
  • src/assets/images/roo.png

4. Unrelated Changes

Many files in this PR appear unrelated to adding a new provider:

  • Changes to terminal process files
  • Changes to various test files
  • .gitignore modifications

5. PR Template Not Completed

  • No linked GitHub issue
  • PR description is empty (template not filled out)
  • Pre-submission checklist items are not checked

Required Actions

To make this PR acceptable:

  1. Remove ALL rebranding changes - Keep only the s2scopilot provider code
  2. Remove ca-bundle.crt - Use environment variable or config option for custom CA certificates instead
  3. Remove rename.png and s2sCopilot.jpg - These do not belong in the repo
  4. Keep ONLY the actual provider implementation files:
    • packages/types/src/providers/s2scopilot.ts
    • packages/types/src/provider-settings.ts (only s2scopilot schema additions)
    • src/api/providers/s2scopilot.ts
    • src/api/providers/fetchers/s2scopilot.ts
    • src/api/index.ts (only the s2scopilot case)
    • src/api/providers/fetchers/modelCache.ts (only s2scopilot additions)
    • webview-ui/src/components/settings/providers/S2sCopilot.tsx
    • Related webview component updates
  5. Fill out the PR template properly
  6. Create a linked issue if this is a feature request

It appears this branch is from a customized fork intended for internal use at an enterprise. The provider addition itself may be valuable, but it needs to be cleanly separated from the internal customizations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant