Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Jan 25, 2026

Fixes issue where .roo folder was excluded from indexing due to blanket hidden directory exclusion.

Problem

The .roo folder was being excluded from codebase indexing because of the ".*" pattern in DIRS_TO_IGNORE, which filters out all hidden directories (those starting with a dot). This prevented worktrees and other environments from indexing important project configuration like:

  • Custom modes
  • Project rules
  • Skills
  • Other .roo configuration files

Solution

Modified isPathInIgnoredDirectory() in src/services/glob/ignore-utils.ts to explicitly exempt the .roo folder from hidden directory filtering while still blocking other hidden directories like .git, .vscode, etc.

Changes

  • Modified isPathInIgnoredDirectory() to skip .roo when checking against the ".*" pattern
  • Added comprehensive test coverage (18 tests) for .roo folder indexing behavior
  • All existing tests pass with no regressions

Testing

  • ✅ New tests: 18 passed
  • ✅ Existing glob tests: 38 passed
  • ✅ Scanner tests: 7 passed
  • ✅ All type checks pass
  • ✅ All linting passes

View task on Roo Code Cloud


Important

Exempt .roo folder from being ignored in isPathInIgnoredDirectory() to allow indexing, with comprehensive test coverage added.

  • Behavior:
    • isPathInIgnoredDirectory() in ignore-utils.ts modified to exempt .roo from hidden directory filtering.
    • .roo folder and its contents are now indexed, unlike other hidden directories.
  • Testing:
    • Added 18 new tests in ignore-utils.spec.ts to verify .roo folder handling.
    • Tests ensure .roo is not ignored, while other hidden directories are.
    • All existing tests pass without regressions.

This description was created by Ellipsis for c683a17. You can customize this summary. It will automatically update as commits are pushed.

The .roo folder was being excluded from indexing due to the blanket
hidden directory exclusion pattern (.*) in DIRS_TO_IGNORE. This fix
explicitly exempts the .roo folder from that filtering to allow
codebase_search to index project configuration, modes, rules, and skills.

Changes:
- Modified isPathInIgnoredDirectory() to skip .roo when checking hidden dirs
- Added comprehensive test coverage for .roo folder indexing behavior
- All existing tests pass with no regressions

Fixes issue where worktree .roo folders were not being indexed
@roomote
Copy link
Contributor Author

roomote bot commented Jan 25, 2026

Rooviewer Clock   See task on Roo Cloud

Review completed with no issues found. The implementation correctly exempts .roo from hidden directory filtering while maintaining all other ignore rules. Test coverage is comprehensive (18 new tests) and all existing tests pass.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

2 participants